Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove similar check endpoints from GOCDB_monitor #502

Open
gregcorbett opened this issue Dec 14, 2023 · 0 comments
Open

Remove similar check endpoints from GOCDB_monitor #502

gregcorbett opened this issue Dec 14, 2023 · 0 comments
Labels
enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day

Comments

@gregcorbett
Copy link
Member

There are currently three such endpoints:

  • ops_monitor_check.php: Which is the endpoint used by EGI Operations, returns a 500 status on an error, and accepts a fake_failure parameter to fake a failure.
  • check.php: Used by internal monitoring, returns a 500 status on an error (post Add http response code to check.php #501)
  • check_with_error.php: Always returns a php error code of 2, and a http status of 200.

I would suggest check_with_error.php is removed, and ops_monitor_check.php is coalesced into check.php (preserving the fake_failure behaviour).
@gregcorbett gregcorbett added enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregcorbett