Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit config #497

Open
gregcorbett opened this issue Nov 20, 2023 · 0 comments
Open

Add a pre-commit config #497

gregcorbett opened this issue Nov 20, 2023 · 0 comments
Labels
enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day

Comments

@gregcorbett
Copy link
Member

Similar to the config for APEL's SSM: https://github.com/apel/ssm/blob/dev/.pre-commit-config.yaml, GOCDB should at least have the following checks

  # Other checks
  - id: check-added-large-files
  - id: check-merge-conflict
  - id: check-yaml
  - id: debug-statements
  - id: end-of-file-fixer
  - id: mixed-line-ending
    name: Force line endings to LF
    args: ['--fix=lf']
  - id: trailing-whitespace

It would be useful to look if there are PHP specific checks we can use and if so, potentially included them.

@gregcorbett gregcorbett added enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day
Projects
None yet
Development

No branches or pull requests

1 participant