Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone improvements to {add, edit}_downtime #495

Open
2 tasks
gregcorbett opened this issue Oct 23, 2023 · 1 comment
Open
2 tasks

Timezone improvements to {add, edit}_downtime #495

gregcorbett opened this issue Oct 23, 2023 · 1 comment
Labels
enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day question

Comments

@gregcorbett
Copy link
Member

Relates to #86

The Javascript elements on the downtime pages lead to some confusing behaviour when time offsets change (i.e. summer time to winter time).

image

In this case, the downtime should end at 30/10/2023 12:00 UTC, not 11:00 UTC - as the London/Europe timezone on the 30th is UTC. But when the downtime was entered, the London/Europe timezone was UTC-1 - hence 12:00.

  • A relativity quick fix would be updating Site Timezone: Europe/London to something like Site Timezone: {UTC, UTC-1} (Europe/London) (or even just Site Timezone: {UTC, UTC-1} ) would make the behaviour clear - as it's more explicit that a fixed offset is being applied.
  • A braver solution is reworking the timezone logic. We should look as to how feasible this is.
@gregcorbett gregcorbett added enhancement question good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day labels Oct 23, 2023
@gregcorbett
Copy link
Member Author

A braver solution is reworking the timezone logic. We should look as to how feasible this is.

A good first step would be to create a toy example similar to the downtime page date/time picker that can handle StartTime and EndTime being in two different UTC offsets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day question
Projects
None yet
Development

No branches or pull requests

1 participant