Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are style="" blocks needed on ServiceGroup pages? #445

Open
gregcorbett opened this issue Mar 28, 2023 · 0 comments
Open

Are style="" blocks needed on ServiceGroup pages? #445

gregcorbett opened this issue Mar 28, 2023 · 0 comments
Labels
good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day question

Comments

@gregcorbett
Copy link
Member

style="" is used to a limited extent in the codebase - seemingly limited to pages around ServiceGroups.

A grep of the 5.10.4 codebase gave

> grep -RHn "style=\"\"" *
htdocs/web_portal/views/service_group/add_service_group.php:25:              <span class="input_name" style="">
htdocs/web_portal/views/service_group/add_new_se_to_service_group.php:90:    <span class="input_name" style="">

And #209 introduced some others, following the precedent.

We should determine the effect of removing style="" from the codebase and do it in one go if that's determined to be the best thing.

Otherwise, we should add comments why the empty style blocks are needed.

@gregcorbett gregcorbett added question good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day labels Mar 28, 2023
@gregcorbett gregcorbett changed the title Are style="" blocks needed on ServiceGroup pages Are style="" blocks needed on ServiceGroup pages? Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that require "minimal" knowledge of the codebase hackathon Issues that could be solved within a day question
Projects
None yet
Development

No branches or pull requests

1 participant