Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] hazard_type and process_type, where should they sit? #96

Closed
odscjen opened this issue Jun 19, 2023 · 4 comments · Fixed by #121
Closed

[Discussion] hazard_type and process_type, where should they sit? #96

odscjen opened this issue Jun 19, 2023 · 4 comments · Fixed by #121
Assignees
Labels
hazard Issues related to Hazard data proposal New feature or request

Comments

@odscjen
Copy link
Contributor

odscjen commented Jun 19, 2023

Currently the schema has the Hazard type in event_set.hazard_type and the Process type in footprint_set.process_type. But in #91 (comment) the example given has them both in event_set.

Where should they sit? From the discussion linked to I'm assuming we should move process_type to event_set? @stufraser1 @matamadio is this correct?

@odscjen odscjen added proposal New feature or request hazard Issues related to Hazard data labels Jun 19, 2023
@stufraser1
Copy link
Member

Yes we should move process_type to event_set

@odscjen
Copy link
Contributor Author

odscjen commented Jun 27, 2023

Just reviewing #91 and note that hazard_type is also being discussed there as part of event. So should process_type be available in event as well as event_set

@odscrachel
Copy link
Contributor

I've moved process_type from footprint to event_set in #121. @stufraser1 let me know if this also needs to be added to event per Jen's last comment.

@odscrachel odscrachel mentioned this issue Jul 4, 2023
2 tasks
@stufraser1
Copy link
Member

stufraser1 commented Jul 5, 2023

let me know if this also needs to be added to event per Jen's last comment.

yes please add process_typez to event`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hazard Issues related to Hazard data proposal New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants