Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Explore country page: Combine results from Categories/Hazards and Country Groups filters #338

Open
CIMAManuel opened this issue Nov 30, 2018 · 4 comments

Comments

@CIMAManuel
Copy link
Collaborator

Categories/Applicability filter and Country Group must work togher.

@thom4parisot
Copy link

thom4parisot commented Nov 30, 2018

For the record, this bug is present because #326 has been merged in spite of this change being asked for. I mentioned I was looking into it, clarifying whether it required "more code and no API change" or "no code change and an API change" (making /api/country/ on par with /api/country_score/ filters)

An issue which happen during an iteration can only be scheduled for a next iteration unless it is operation critical (eg: Global data page not working).

@pzwsk
Copy link
Collaborator

pzwsk commented Nov 30, 2018

Ok thanks @oncletom

I recommended @CIMAManuel to open this issue because I understood it was blocking the deployment of new Country Groups list on Prod.

To me it is not a bug per se but more a clarification/enhancement on how Country Filters should behave that has been overlooked when we defined the issue at first.

Now, I understand this feature is working on Exp FE but I don't know what has been done and how. @CIMAManuel can you explain?

Also, actually I don't understand why this issue would be blocking the use of new Country Groups list? If this not the case, it is less urgent then.

Could you please continue discuss it here?

Many thanks

@pzwsk pzwsk changed the title Explore country page: Categories and Coutry group filters Explore country page: Combine results from Categories/Hazards and Country Groups filters Nov 30, 2018
@CIMAManuel
Copy link
Collaborator Author

@pzwsk exp has a old FE version, I updated it to test my changes to Explore countries but these changes was revert by @oncletom so I think exp is not to consider now. EXP is only a "test area".
I activate bug label because I thought this issue was a request and to remind that this page is "incomplite" because last PR was approved for urgency and I think this issue is not basic for deploy.
So, we can do that (if necessary) in next iteration.
Let me Know.

Thanks

@pzwsk
Copy link
Collaborator

pzwsk commented Nov 30, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants