Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SE) Cleaning up Logger implementation #428

Open
mranst opened this issue Sep 17, 2024 · 0 comments
Open

(SE) Cleaning up Logger implementation #428

mranst opened this issue Sep 17, 2024 · 0 comments

Comments

@mranst
Copy link
Contributor

mranst commented Sep 17, 2024

In adding type hinting for swell, we discovered that the implementation of Logger could be improved:

  • Implement Logger (from swell.utilities.logger) as an inherited class of logging.Logger. This would simplify annotations and make it possible for swell code to simply use logging.Logger where sufficient

This would resolve possible confusion in cases such as in slurm_test.py, which passes a logging.Logger object to SWELLError, where most other functions specifically expect a swell logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant