-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Pinned Hashes for JEDI Repositories #433
Conversation
…GEOS-ESM/swell into feature/pinned_versions_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
In addition to the stuff in my review, one more requested change (I couldn't add a suggestion because it's too far from any code you touched): In src/swell/tasks/task_questions.yaml
line 466 (definition of jedi_build_method
), we need to add the new valid options.
Also, if we do that, is there a way to enforce a particular set of options at runtime? I.e., When you go to set self.config.jedi_build_method
, if it's set to something invalid, it'll fail immediately? Not sure if the string-drop-list
or some other type
will do that for us. In any case, if there's a way to easily do that, we should do it, because that will allow us to remove lots of if self.config.jedi_build_method() in (...)
code blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
We just need to ensure the consistency of pinned_versions.yaml
and the following locations:
swell/src/swell/deployment/platforms/nccs_discover_sles15/task_questions.yaml
Lines 10 to 14 in 597bbbe
existing_jedi_build_directory: | |
default_value: /discover/nobackup/projects/gmao/advda/swell/JediBundles/fv3_soca_SLES15/build-intel-release | |
existing_jedi_source_directory: | |
default_value: /discover/nobackup/projects/gmao/advda/swell/JediBundles/fv3_soca_SLES15 |
…GEOS-ESM/swell into feature/pinned_versions_support
I modified the platform task_question.yaml files to point to pinned version jedi bundles for SLES12 and SLES15. |
In |
Description
Adds two options for using pinned versions in swell experiments:
pinned_create
jedi build method. Calling this method will clone jedi repositories with hashes inpinned_versions.yaml
. Then it will build jedi and proceed as normal.use_pinned_existing
jedi build method. This will point tobuild
andsource
directories in/discover/nobackup/projects/gmao/advda/jedi_bundles
or/discover/nobackup/projects/gmao/advda/jedi_bundles_sles15
for milan nodes. This build is currently pinned to August 31st. Thecheck_hashes
script is called to check if commit hashes in this build lines up withpinned_versions.yaml
. If it does not, it will abort. If it does, it will proceed as normal.Note that none of these options are default and they must be indicated through the CLI.
Notes
use_pinned_existing
fails will be addressed in another PRIssues
Resolves #423
Addresses some concerns in #345