Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History needs to check if a file already exists when it decides it is time to write a new file #1565

Closed
bena-nasa opened this issue Jun 13, 2022 · 0 comments
Assignees
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature

Comments

@bena-nasa
Copy link
Collaborator

bena-nasa commented Jun 13, 2022

The title says it all, I'll be making a PR here soon.

Each time History runs, it must make a determine if it is time to write a collection and if the file is a new file or if we are appending to the file like in the case when you have multiple time steps per file. We do not check that if the file is new, that it does not already exist. I'm going to put that protection in because I wasted many hours chasing a problem with the DAS because we do not have this check which leads to a more confusing error later that would have been clear had we caught this in the gridcomp. Note the issue I found in the DAS is not a MAPL issue other than that we let an error get too far; the DAS scripts need to remove files as I detailed in this issue I opened in the DAS repo:

GEOS-ESM/GEOSadas#188

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jun 13, 2022
@bena-nasa bena-nasa self-assigned this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

No branches or pull requests

1 participant