Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide AK BK through Configfile for AdvCore #50

Open
weiyuan-jiang opened this issue Apr 24, 2020 · 2 comments
Open

provide AK BK through Configfile for AdvCore #50

weiyuan-jiang opened this issue Apr 24, 2020 · 2 comments

Comments

@weiyuan-jiang
Copy link
Contributor

DynCore can read AK-BK through the configure file, but not the AdvCore. To provide AdvCore with such function, we can create a reading subroutine shared by both cores. Or, we can simply copy those lines from Dyncore to AdvCore.

call ESMF_ConfigFindLabel( cf, 'AK:', isPresent=isPresent, rc = status )
VERIFY_(STATUS)
if (isPresent) then
do L = 0, SIZE(AK)-1
call ESMF_ConfigNextLine ( CF, rc=STATUS )
call ESMF_ConfigGetAttribute( cf, AK(L), rc = status )
VERIFY_(STATUS)
enddo
else
ak_is_missing = .true.
endif
call ESMF_ConfigFindLabel( cf, 'BK:', isPresent=isPresent, rc = status )
VERIFY_(STATUS)
if (isPresent) then
do L = 0, SIZE(bk)-1
call ESMF_ConfigNextLine ( CF, rc=STATUS )
call ESMF_ConfigGetAttribute( cf, BK(L), rc = status )
VERIFY_(STATUS)
enddo
else
bk_is_missing = .true.
endif
@tclune

@weiyuan-jiang
Copy link
Contributor Author

Reminding you of this issue in case you forgot. @tclune

@tclune
Copy link
Collaborator

tclune commented May 4, 2020

@wmputman Bill, do you have a recommended location for us to refactor the common logic for getting Ak and Bk for the DynCore and AdvCore? We can create a new file or put it in some existing file. (Am assuming you are ok with the basic concept.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants