Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W is not set when Hydrostatic is TRUE #121

Open
mmanyin opened this issue Jun 24, 2021 · 3 comments
Open

W is not set when Hydrostatic is TRUE #121

mmanyin opened this issue Jun 24, 2021 · 3 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@mmanyin
Copy link
Contributor

mmanyin commented Jun 24, 2021

W is an export from DYN, but in DynCore_GridCompMod.F90 it is only set when Hydrostatic is FALSE. To remedy this I have introduced code to compute W, in the branch feature/mmanyin/export_W_when_HYDROSTATIC. I would welcome feedback on the approach that I've taken.

@mathomp4 mathomp4 added the question Further information is requested label Jun 25, 2021
@mathomp4
Copy link
Member

Well this is a @wmputman sort of thing. Here is a comparison link for Bill:

develop...feature/mmanyin/export_W_when_HYDROSTATIC

@mmanyin mmanyin added the bug Something isn't working label Feb 3, 2022
@mmanyin
Copy link
Contributor Author

mmanyin commented Aug 5, 2022

Just checking in on this...
@wmputman - to compute W, is it acceptable to save OMEGA from Run1, and then in Run2:

if (HYDROSTATIC) then
call MAPL_GetPointer(export,temp3d,'W', rc=status)
VERIFY_(STATUS)
if(associated(temp3d)) temp3d = -1.0 * save_omega * (zle(:,:,1:km)-zle(:,:,2:km+1)) / dp

thanks

@wmputman
Copy link
Contributor

I would rather just leave this to fill with all 0's or undefs. It should be a nonhydrostatic export exclusively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants