Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with cmake and MKL on laptops #60

Open
bena-nasa opened this issue Mar 20, 2020 · 2 comments
Open

Issue with cmake and MKL on laptops #60

bena-nasa opened this issue Mar 20, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bena-nasa
Copy link
Collaborator

The cmake command may require -DMKL_Fortran=on depending on the MKL, the actually issue seems to be with the FindMKL.cmake in ecbuild.

@mathomp4
Copy link
Member

@bena-nasa Did you try changing this bit of esma.cmake:

ESMA_cmake/esma.cmake

Lines 68 to 71 in df6e079

if (APPLE)
if (DEFINED ENV{MKLROOT})
set (MKL_Fortran)
find_package (MKL REQUIRED)

to be set(MKL_Fortran ON)? It seems equivalent to what's there before.

Or even the full on:

set(MKL_Fortran ON CACHE BOOL "Set MKL_Fortran on")

@mathomp4 mathomp4 assigned mathomp4, tclune and bena-nasa and unassigned mathomp4 Mar 23, 2020
@tclune
Copy link
Collaborator

tclune commented Mar 23, 2020

Hmm. I was lazy and had not even realized that we'd previously added logic outside the FindMKL file. I guess it is not quite correct as it stands.

Probably should instead use

option(MKL_Fortran "Allow building without C bindings for MKL" ON)

@bena-nasa Can you test and submit a PR?

@tclune tclune added the bug Something isn't working label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants