gam-install.sh - Linux/MacOS directory builds accumulating old dist-info files

[taers232c]

When updating an existing gam7 installation, the tar extraction updates files in the lib subdirectory getting the latest dist-info files but leaves old versions of dest-info files in the directory.

mkdir -p "$target_dir"

echo_yellow "Extracting archive to $target_dir"
if [[ "$name" =~ tar.xz|tar.gz|tar ]]; then
  tar $strip_gam -xf "$temp_archive_dir"/"$name" -C "$target_dir"
elif [[ "$name" == *.zip ]]; then
  unzip -o "${temp_archive_dir}/${name}" -d "${target_dir}"
else
  echo "I don't know what to do with files like ${name}. Giving up."
  exit 1
fi

Adding this rm -fr "$target_dir/gam7/lib/*" after the mkdir -p "$target_dir" will empty the lib subdirectory and old dist-info files will not accumulate.

[jay0lee]

This is in gam-install.sh, right?

[jay0lee]

Does GAM throw an error due to the old files or is it just that we shouldn't leave old files around?

[taers232c]

It doesn't throw an error, old file are accumulation. Clean: $ du -hs * 352K GamCommands.txt 840K GamUpdate.txt 12K LICENSE 68K cacerts.pem 8.8M gam 42M lib Old stuff: $ du -hs * 352K GamCommands.txt 840K GamUpdate.txt 12K LICENSE 68K cacerts.pem 8.8M gam 44M lib 2M of old stuff. Ross ---- Ross Scroggs ***@***.***

…

On Dec 23, 2024, at 10:24 AM, Jay Lee ***@***.***> wrote: Does GAM throw an error due to the old files or is it just that we shouldn't leave old files around? — Reply to this email directly, view it on GitHub <#1732 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCTYL44WBDCOREAPYZY6I32HBIO3AVCNFSM6AAAAABUDO46MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGEZTCOJXG4>. You are receiving this because you authored the thread.

[jay0lee]

Yeah so clearing lib just before we extract makes sense. Try adding a -v to the command so we verbosely report what we're doing just in case there's an error.

…

On Mon, Dec 23, 2024, 1:31 PM Ross Scroggs ***@***.***> wrote: It doesn't throw an error, old file are accumulation. Clean: $ du -hs * 352K GamCommands.txt 840K GamUpdate.txt 12K LICENSE 68K cacerts.pem 8.8M gam 42M lib Old stuff: $ du -hs * 352K GamCommands.txt 840K GamUpdate.txt 12K LICENSE 68K cacerts.pem 8.8M gam 44M lib 2M of old stuff. Ross ---- Ross Scroggs ***@***.*** > On Dec 23, 2024, at 10:24 AM, Jay Lee ***@***.***> wrote: > > > Does GAM throw an error due to the old files or is it just that we shouldn't leave old files around? > > — > Reply to this email directly, view it on GitHub < #1732 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL44WBDCOREAPYZY6I32HBIO3AVCNFSM6AAAAABUDO46MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGEZTCOJXG4>. > You are receiving this because you authored the thread. > — Reply to this email directly, view it on GitHub <#1732 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDIZMA7BIRR3W7EMQKWRYD2HBJH7AVCNFSM6AAAAABUDO46MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGEZTSNJRGY> . You are receiving this because you were assigned.Message ID: ***@***.***>