Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dict subclassing in templates and terminologies #329

Open
mpsonntag opened this issue Oct 16, 2019 · 0 comments
Open

dict subclassing in templates and terminologies #329

mpsonntag opened this issue Oct 16, 2019 · 0 comments

Comments

@mpsonntag
Copy link
Contributor

Subclassing the dict built-in is generally discouraged (and collections.UserDict exists for this purpose) but I think the reasons for that don't affect us here right now. I believe it's only an issue when overriding the magic methods, which we're not. Might want to keep in mind in case we do anything more fancy with the class.

Originally posted by @achilleas-k in https://github.com/G-Node/python-odml/diffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant