Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable check for __eq__ on subclasses #487

Open
achilleas-k opened this issue Nov 20, 2020 · 0 comments
Open

Disable check for __eq__ on subclasses #487

achilleas-k opened this issue Nov 20, 2020 · 0 comments

Comments

@achilleas-k
Copy link
Member

LGTM produces alerts for __eq__ not overridden when adding attributes. Entity objects are compared for equality based on their ID. LGTM expects subclasses to override __eq__ when attributes are added, but we don't need to.

We should find a way to disable these warnings for our Entity subclasses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achilleas-k