Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating question #1

Open
Martii opened this issue Dec 13, 2019 · 0 comments
Open

Updating question #1

Martii opened this issue Dec 13, 2019 · 0 comments

Comments

@Martii
Copy link

Martii commented Dec 13, 2019

Presuming you actually want script updates to occur from GitHub you should probably, at least, do this:

--- /scripts/Fuzzwah/iRacing_Hide_Unwanted_Series/[email protected]+b4045ae
+++ /scripts/Fuzzwah/iRacing_Hide_Unwanted_Series/source
@@ -9,7 +9,7 @@
 // @copyright     2019+, fuzzwah (https://github.com/fuzzwah)
 // @license       MIT; https://raw.githubusercontent.com/fuzzwah/iRacing-Hide-Unwanted/master/LICENSE
 // @homepageURL   http://www.fuzzwahracing.com/p/hide-unwanted.html
-// @updateURL     https://raw.githubusercontent.com/fuzzwah/iRacing-Hide-Unwanted/master/iRacing-Hide-Unwanted.user.js
+// @downloadURL   https://raw.githubusercontent.com/Fuzzwah/iRacing-Hide-Unwanted/master/iRacing-Hide-Unwanted.user.js
 // ==/UserScript==
 var load, execute, loadAndExecute, executeJQuery
 ;(load = function(a, b, c) {

This means check OUJS for updates and download from GitHub.

As it stands you are having your installers check to see if there is an update on GitHub but then the .user.js engine downloads whatever version is hosted on OUJS even if it's older and not updated.

Is this really what you want to do?

Thanks for the look,
OUJS Admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant