Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

Async file handling #34

Open
aesteve opened this issue Jun 5, 2018 · 1 comment
Open

Async file handling #34

aesteve opened this issue Jun 5, 2018 · 1 comment

Comments

@aesteve
Copy link
Contributor

aesteve commented Jun 5, 2018

When looking at https://github.com/FroMage/redpipe/blob/master/redpipe-engine/src/main/java/net/redpipe/engine/resteasy/FileResource.java#L19

It seems that file handling is directly delegated to RestEasy. Not sure how it's implemented in details, but I'm concerned by the fact it might use blocking IO.

We could consider using Vert.x build-in  FileSystem which exposes some utilities regarding asynchronous IO.

@FroMage
Copy link
Owner

FroMage commented Jun 5, 2018

Yes, very good idea. We'd just need to do the same as RESTEasy does wrt preconditions and caching.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants