Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automated tests #334

Closed
hex333ham opened this issue May 5, 2019 · 3 comments
Closed

automated tests #334

hex333ham opened this issue May 5, 2019 · 3 comments
Labels
help wanted Need help on this issue
Milestone
Symfony 4 support

Comments

@hex333ham
Copy link
Collaborator

similar to #333 , exists but not mentioned in docs

also has the following results with deprecation notices on 4.0 (probably not an issue, testing on latest in a moment):

php bin/phpunit vendor/friendsofsymfony/message-bundle/Tests
#!/usr/bin/env php
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Testing vendor/friendsofsymfony/message-bundle/Tests
I................                                                 17 / 17 (100%)

Time: 514 ms, Memory: 24.00MB

OK, but incomplete, skipped, or risky tests!
Tests: 17, Assertions: 29, Incomplete: 1.

Remaining deprecation notices (3)

  2x: A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.
    2x in FunctionalTest::testController from FOS\MessageBundle\Tests\Functional

  1x: The "FOS\MessageBundle\Controller\MessageController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
    1x in FunctionalTest::testController from FOS\MessageBundle\Tests\Functional
@hex333ham hex333ham added this to the Symfony 4 support milestone May 5, 2019
@hex333ham hex333ham self-assigned this May 5, 2019
@hex333ham hex333ham mentioned this issue May 5, 2019
Closed
@hex333ham hex333ham changed the title tests automated tests May 5, 2019
@hex333ham
Copy link
Collaborator Author

4.2 gives off more deprecation errors:

PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Testing vendor/friendsofsymfony/message-bundle/Tests
I................                                                 17 / 17 (100%)

Time: 7.72 seconds, Memory: 24.00MB

OK, but incomplete, skipped, or risky tests!
Tests: 17, Assertions: 29, Incomplete: 1.

Remaining deprecation notices (3)

  2x: A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.
    2x in FunctionalTest::testController from FOS\MessageBundle\Tests\Functional

  1x: The "FOS\MessageBundle\Controller\MessageController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
    1x in FunctionalTest::testController from FOS\MessageBundle\Tests\Functional

@hex333ham
Copy link
Collaborator Author

hex333ham commented May 5, 2019 •
edited
Loading

tests pass(ish), but these notices will need fixing

@hex333ham hex333ham added help wanted Need help on this issue and removed bug in progress labels May 5, 2019
@hex333ham hex333ham removed their assignment May 5, 2019
@hex333ham
Copy link
Collaborator Author

this has been fixed in branch https://github.com/FriendsOfSymfony/FOSMessageBundle/tree/1.4

moving discussion to #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Need help on this issue
Projects
None yet
Milestone
Symfony 4 support
Development

No branches or pull requests
1 participant
@hex333ham