Add .github/workflows with fixes (#52)

add .github/workflows with fixes
FriendsOfDoctrine · Oct 24, 2022 · 74536d6 · 74536d6
1 parent 3eb4fb7
commit 74536d6
Show file tree

Hide file tree

Showing 7 changed files with 109 additions and 44 deletions.
diff --git a/.flintci.yml b/.flintci.yml
diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml
@@ -0,0 +1,38 @@
+name: Static analysis
+
+on:
+  push:
+  pull_request:
+
+concurrency:
+    group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+    cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+  phpstan:
+    name: PHPStan
+    runs-on: Ubuntu-20.04
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.1'
+          extensions: pdo
+          ini-values: "memory_limit=-1"
+          coverage: none
+          tools: phpstan
+
+      - name: Install dependencies
+        run: |
+          composer config --no-plugins allow-plugins.dealerdirect/phpcodesniffer-composer-installer false
+          composer install --prefer-dist
+
+      - name: phpstan
+        run: phpstan analyse -l 5 src
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -0,0 +1,48 @@
+name: Tests
+
+on:
+  push:
+  pull_request:
+
+concurrency:
+    group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+    cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+
+  tests:
+    name: Tests
+    runs-on: Ubuntu-20.04
+
+    strategy:
+      matrix:
+        php-versions: ['7.1', '7.4', '8.0', '8.1']
+      fail-fast: false
+
+    services:
+      clickhouse:
+        image: yandex/clickhouse-server
+        ports:
+          - 8123:8123
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-versions }}
+          extensions: pdo
+          ini-values: "memory_limit=-1"
+          tools: composer
+          coverage: xdebug
+
+      - name: Install dependencies
+        run: composer install --prefer-dist
+
+      - name: Run tests
+        run: ./vendor/bin/phpunit --configuration ./phpunit.xml.dist --coverage-text
diff --git a/.travis.yml b/.travis.yml
diff --git a/composer.json b/composer.json
@@ -44,5 +44,10 @@
         "psr-4": {
             "FOD\\DBALClickHouse\\Tests\\": "tests/"
         }
+    },
+    "config": {
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
     }
 }
diff --git a/src/ClickHouseStatement.php b/src/ClickHouseStatement.php
@@ -241,27 +241,31 @@ public function fetchColumn($columnIndex = 0)
     /**
      * {@inheritDoc}
      */
-    public function bindValue($param, $value, $type = null)
+    public function bindValue($param, $value, $type = null): bool
     {
         $this->values[$param] = $value;
         $this->types[$param]  = $type;
+
+        return true;
     }
 
     /**
      * {@inheritDoc}
      */
-    public function bindParam($column, &$variable, $type = null, $length = null)
+    public function bindParam($column, &$variable, $type = null, $length = null): bool
     {
         $this->values[$column] = &$variable;
         $this->types[$column]  = $type;
+
+        return true;
     }
 
-    public function errorCode() : void
+    public function errorCode() : int
     {
         throw new ClickHouseException('You need to implement ClickHouseStatement::' . __METHOD__ . '()');
     }
 
-    public function errorInfo() : void
+    public function errorInfo() : array
     {
         throw new ClickHouseException('You need to implement ClickHouseStatement::' . __METHOD__ . '()');
     }

diff --git a/src/Connection.php b/src/Connection.php
@@ -40,15 +40,15 @@ public function executeUpdate($query, array $params = [], array $types = []) : i
     /**
      * @throws ClickHouseException
      */
-    public function delete($tableExpression, array $identifier, array $types = []) : void
+    public function delete($tableExpression, array $identifier, array $types = []) : int
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
 
     /**
      * @throws ClickHouseException
      */
-    public function update($tableExpression, array $data, array $identifier, array $types = []) : void
+    public function update($tableExpression, array $data, array $identifier, array $types = []) : int
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
@@ -60,23 +60,23 @@ public function update($tableExpression, array $data, array $identifier, array $
     /**
      * @throws ClickHouseException
      */
-    public function setTransactionIsolation($level) : void
+    public function setTransactionIsolation($level) : int
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
 
     /**
      * @throws ClickHouseException
      */
-    public function getTransactionIsolation() : void
+    public function getTransactionIsolation() : int
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
 
     /**
      * @throws ClickHouseException
      */
-    public function getTransactionNestingLevel() : void
+    public function getTransactionNestingLevel() : int
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
@@ -100,31 +100,31 @@ public function setNestTransactionsWithSavepoints($nestTransactionsWithSavepoint
     /**
      * @throws ClickHouseException
      */
-    public function getNestTransactionsWithSavepoints() : void
+    public function getNestTransactionsWithSavepoints() : bool
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
 
     /**
      * @throws ClickHouseException
      */
-    public function beginTransaction() : void
+    public function beginTransaction() : bool
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
 
     /**
      * @throws ClickHouseException
      */
-    public function commit() : void
+    public function commit() : bool
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
 
     /**
      * @throws ClickHouseException
      */
-    public function rollBack() : void
+    public function rollBack() : bool
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }
@@ -164,7 +164,7 @@ public function setRollbackOnly() : void
     /**
      * @throws ClickHouseException
      */
-    public function isRollbackOnly() : void
+    public function isRollbackOnly() : bool
     {
         throw ClickHouseException::notSupported(__METHOD__);
     }