Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't view locked units #1691

Closed
DreadKnight opened this issue Jul 3, 2020 · 7 comments
Closed

can't view locked units #1691

DreadKnight opened this issue Jul 3, 2020 · 7 comments
Labels
coding This issue requires some programming easy Good place to start if you're a new developer priority This should get fixed as soon as possible! visuals Various things that easily catch the eye
Milestone
0.4 - Bounty Hunter

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Jul 3, 2020 •
edited
Loading

Selecting locked units from game's dash view doesn't work anymore.
Once again, this regression... it's getting really really tiresome already.
@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye easy Good place to start if you're a new developer labels Jul 3, 2020
@DreadKnight DreadKnight added this to the 0.4 - Bounty Hunter milestone Jul 3, 2020
@DreadKnight
Copy link
Member Author

DreadKnight commented Jul 3, 2020 •
edited
Loading

Hence why we need them automated testing at some point #997
Anyway, this issue was probably caused by some recent code refactoring, where new data fields playable where added into assets/units/data.json file as of #1680 PR

@carlsopa
Copy link

carlsopa commented Jul 6, 2020

I can take a look at this.

@DreadKnight
Copy link
Member Author

@carlsopa Alright, feel free to do so.

@DreadKnight
Copy link
Member Author

@carlsopa I've assigned you, for 1 week or so xD

@DreadKnight
Copy link
Member Author

@carlsopa Hey, any progress with this? Don't let it drag for too long :)

@DreadKnight DreadKnight added the priority This should get fixed as soon as possible! label Jul 13, 2020
@DreadKnight DreadKnight pinned this issue Jul 21, 2020
@DreadKnight
Copy link
Member Author

This easy issue is up for taking once again. Feel free to simply create a PR!

dylanelliott27 added a commit to dylanelliott27/AncientBeast that referenced this issue Jul 30, 2020
@dylanelliott27
issue FreezingMoon#1691
19b6065
@dylanelliott27 dylanelliott27 mentioned this issue Jul 30, 2020
Merged
DreadKnight added a commit that referenced this issue Aug 2, 2020
@DreadKnight
Merge pull request #1708 from dylanelliott27/issue-#1691
46eb3f4 
fixes issue #1691
DreadKnight added a commit that referenced this issue Aug 2, 2020
@DreadKnight
updated comment for type #1691
c947c9c
@DreadKnight
Copy link
Member Author

Fixed in #1708

@DreadKnight DreadKnight unpinned this issue Aug 2, 2020
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
@dylanelliott27
issue FreezingMoon#1691
27ad769
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
@DreadKnight
Merge pull request FreezingMoon#1708 from dylanelliott27/issue-#1691
d71a2be 
fixes issue FreezingMoon#1691
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
@DreadKnight
updated comment for type FreezingMoon#1691
f2cef70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coding This issue requires some programming easy Good place to start if you're a new developer priority This should get fixed as soon as possible! visuals Various things that easily catch the eye
Projects
None yet
Milestone
0.4 - Bounty Hunter
Development

No branches or pull requests
2 participants
@DreadKnight @carlsopa