Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left-align CSS class not working on Home page buttons #167

Open
DeniseColbert opened this issue Feb 25, 2021 · 6 comments
Open

Left-align CSS class not working on Home page buttons #167

DeniseColbert opened this issue Feb 25, 2021 · 6 comments
Assignees

Comments

@DeniseColbert
Copy link

Home.PNG

@johnshaw1000
Copy link
Collaborator

johnshaw1000 commented Mar 1, 2021

This is difficult to fix. It's not clear what this should look like, generally buttons are centre-aligned. I did use CSS ID to gain some control over the text style, but I couldn't get the icons to align properly at all.

I've tried an alternative using an icon list, which I think formats more in line with what is wanted - but they're clearly not buttons.
Image attached for comparison.
Screenshot 2021-03-01 at 21 23 36

@johnshaw1000
Copy link
Collaborator

Screenshot 2021-03-17 at 18 03 05
I think this change achieves the styling requirements and the links work. @DeniseColbert please review.

@DeniseColbert
Copy link
Author

Looks really good, John, thank you.

No hover focus may be a problem for keyboard-only users- design can look at this and advise.

Just curious, why doesn't the URL of each link show on hover?

@johnshaw1000
Copy link
Collaborator

Screenshot 2021-03-22 at 20 20 22
The previous layout was achieved using <button html elements. This new layout is achieved using <a> (anchor) html elements, hopefully this is much closer to the vision for the homepage.
@DeniseColbert Please review and close this story if you're happy with this.

@DeniseColbert
Copy link
Author

Love this, @johnshaw1000 thanks! Could you put a little distance between the icon and the text?

@johnshaw1000
Copy link
Collaborator

Done. Changed from 10px to 15px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants