Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Volume to District Number for post-1992 records #586

Open
richardofsussex opened this issue Jun 18, 2024 · 8 comments
Open

Change Volume to District Number for post-1992 records #586

richardofsussex opened this issue Jun 18, 2024 · 8 comments
Assignees
Labels
Entry information page MVP Minimum Viable Product (Requirement for launch)

Comments

@richardofsussex
Copy link

In records from 1993 onwards, GRO stopped using Volume and Page, replacing them by Register Number (and SubNumber) and Entry Number, and started recording (GRO) District Number (and SubNumber). With splendid pragmatism, we therefore started recording District Number in the Volume field. This field consists of a three-digit District Number, optionally followed by one or more characters representing a SubNumber.

This means, inter alia, that we should change the Volume heading in the Entry Information page to District Number/SubNumber, and display that field so it is clear which is the Number and which the SubNumber.

@KristinaGadzhieva
Copy link
Collaborator

to investigate more

1 similar comment
@KristinaGadzhieva
Copy link
Collaborator

to investigate more

@richardofsussex
Copy link
Author

On further investigation, I would say that we should not display the Volume field at all when the date is 1993 or later. The GRO District Number is a property of the District (and is distinct from our own District Number). We don't display it for older material - so I see no need to display it for post-1992 material either.

What we do need is the Registration Number. This isn't in BestGuess: it is stored in the Submissions table. It should appear where Volume would normally appear in the Entry Information view, since it plays the role which Volume played.

The other change we should make is that for post-1992 material, the Page is actually called the Entry Number:
image
so we should call it that too in Entry Information.

@richardofsussex
Copy link
Author

Also, I suspect that the 'previous [in page]' and 'next [in page]' navigation will be meaningless for Entry Numbers, and so should be suppressed.

@richardofsussex
Copy link
Author

I also found that the Date wasn't being output for recent years, and the DOR entry code needed to allow for entries of the form 'MMYY' as well as 'MM.YY' (not least because that's what is actually in the source data!).

@richardofsussex
Copy link
Author

The Search results page in beta now displays different information from the Entry information page as regards 'volume' and 'page'. For example:

image

and:

image

This implies that we must accept the overhead of looking up Register number and Entry number, since we will otherwise be displaying incorrect information.

@richardofsussex
Copy link
Author

richardofsussex commented Aug 6, 2024

In fact, further fixing is required. The FreeBMD site has this as the detail for this record:

image

So the BMD2 beta Entry number is actually the Date of Registration (DoR).

@richardofsussex
Copy link
Author

Now fixed:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entry information page MVP Minimum Viable Product (Requirement for launch)
Projects
None yet
Development

No branches or pull requests

3 participants