Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.0 release #115

Open
1 of 3 tasks
luzpaz opened this issue Sep 3, 2024 · 12 comments
Open
1 of 3 tasks

Prepare for 1.0 release #115

luzpaz opened this issue Sep 3, 2024 · 12 comments

Comments

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 3, 2024

This is a catch-all meta-ticket for readying the Snap package for the upcoming 1.0 release

CC @chennes @adrianinsaval

@luzpaz
Copy link
Collaborator Author

luzpaz commented Sep 14, 2024

@furgo16 any interest in helping this along ?

@furgo16
Copy link
Contributor

furgo16 commented Sep 14, 2024

@luzpaz to the measure of my capabilities, sure. How can I help?

@luzpaz
Copy link
Collaborator Author

luzpaz commented Sep 14, 2024

@furgo16 can you test the edge build if I attempt to fix #116 ?

@furgo16
Copy link
Contributor

furgo16 commented Sep 15, 2024

I'm already on the edge channel, but not sure which build I'm supposed to install. Where's the PR for that? Was it just built locally and manually dropped into the edge channel[^1]? Or how should it be installed otherwise?

[^1]: If so, I'd not advise not doing this, as it could be very confusing to users if there is breakage that cannot be traced to actual code.

@luzpaz

Update: if I understand it correctly, this has not been done yet. Let me know when the change is ready for testing. Happy to help if I can.

@furgo16
Copy link
Contributor

furgo16 commented Sep 16, 2024

Also another task on this issue should probably be to update OCT to the same version that will be shipped with 1.0.

@chennes
Copy link
Member

chennes commented Sep 18, 2024

I have synchronized stable with master, so the latest release candidate should match the build used for the weeklies.

@furgo16
Copy link
Contributor

furgo16 commented Sep 18, 2024

@chennes thank you. snap info freecad reports:

channels:
  latest/stable:    0.21.2         2024-01-28  (908) 855MB -
  latest/candidate: 1.0-g60a25135  2024-09-18 (1141) 823MB -
  latest/beta:      0.22-g58b3d021 2024-07-28 (1090) 800MB -
  latest/edge:      1.1-g758674d4  2024-09-18 (1140) 823MB -

Which looks good. The only thing that caught my eye is that the beta channel seems to have stopped updating at some point. If it's supposed to be automatically updated every week from the master branch, it the relese available there should be 1.1-#########.

@luzpaz
Copy link
Collaborator Author

luzpaz commented Oct 4, 2024

Just kickstarted promite-to-beta action. Let see if it updates correctly

@luzpaz
Copy link
Collaborator Author

luzpaz commented Oct 4, 2024

@chennes promote-to-beta is still pulling from master and not main.

/usr/bin/git checkout --progress --force -B master refs/remotes/origin/master
Reset branch 'master'
branch 'master' set up to track 'origin/master'.

Source: https://github.com/FreeCAD/FreeCAD-snap/actions/runs/11180161727/job/31081302946#step:2:61

@chennes
Copy link
Member

chennes commented Oct 4, 2024

@chennes promote-to-beta is still pulling from master and not main.

Is it pulling the snap repo? It's still called "master" here.

@furgo16
Copy link
Contributor

furgo16 commented Oct 4, 2024

Just kickstarted promite-to-beta action. Let see if it updates correctly

That seemed to work:

channels:
  latest/stable:    0.21.2        2024-01-28  (908) 855MB -
  latest/candidate: 1.0-g3d63fc6c 2024-10-01 (1154) 794MB -
  latest/beta:      1.1-g7a37ea9b 2024-10-04 (1155) 823MB -
  latest/edge:      1.1-g7a37ea9b 2024-10-04 (1155) 823MB -

On a different note: is there really a need for the beta channel? It's effectively an automated weekly snapshot of edge without further testing or guarantee to stability. Would users not be better off using edge?

I don't have a strong opinion on this, I just feel it might reduce maintenance overhead (and potentially confusion, since beta is effectively edge-weekly).

@luzpaz
Copy link
Collaborator Author

luzpaz commented Oct 6, 2024

I don't see any extra overheard, honestly.
To rephrase, it's the FreeCAD 'weekly build' for Snap packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants