current download link is dead

[1tylermitchell]

Freecad.org - Download button links to a location that has a typo in it:
https://www.freecad.org/downloads.phpen

https://www.freecad.org/downloads.php - this works, so looks like a language tags is getting added by mistake or is not being processed correctly.

[1tylermitchell]

Umm, looks like other links on the site have the same problem too!

[chennes]

@kkremitzki orr @yorikvanhavre any idea why this is happening?

[deltafactory]

@chennes It's related to the locale code moved to translation.php. Specifically, $lang = 'en'; which is appended to the URLs in header.php.

Prior to the latest commit, I believe $lang would either be blank or set to a querystring parameter based on the language specified in $_GET['lang'] (i.e. ?lang=en).

[deltafactory]

PR #175 looks like it should fix this with minimal changes.

[kkremitzki]

Broadly speaking, we have a variable type overload--$lang is being used to store an ISO 639 language code like "en", but also a URL query string like "?lang=en".

[kkremitzki]

Temporary workaround to this pushed via 4e90896 but leaving this open for discussion on the underlying issue I mentioned in the previous comment

[yorikvanhavre]

My fault, sorry :/ Just submitted a PR for it