Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-facing strings should be centralised into a single data file #41

Open
Laura7089 opened this issue Apr 6, 2021 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@Laura7089
Copy link
Member

At the moment, strings which are sent by the bot to users are typically defined inline in the code.
Moving these out of the source files and into their own data file allows us to standardise grammar, spelling, emoji use, etc etc. much more conveniently.

Strings which require data inserting into them should comply with python's string format spec and should use keyword arguments to show what should be passed to the .format() method.

Strings within the file should be grouped by global/cog scoping to allow more concise access.

The relevant section from the file should be loaded and cached upon loading of each cog.

Location and format of file to be decided at a later date.

@Laura7089 Laura7089 added the enhancement New feature or request label Apr 6, 2021
@Laura7089
Copy link
Member Author

See #43 and #42

@Laura7089
Copy link
Member Author

See this comment: #71 (comment)

@Laura7089
Copy link
Member Author

Doing this also makes translation and localisation steps easier by far.

@Laura7089 Laura7089 removed their assignment Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant