Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rollback to when there are db errors #227

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Added rollback to when there are db errors #227

wants to merge 1 commit into from

Conversation

Fluxticks
Copy link
Collaborator

@Fluxticks Fluxticks added the enhancement New feature or request label Feb 13, 2022
@Fluxticks Fluxticks requested a review from Ryth-cs February 13, 2022 19:12
@Laura7089
Copy link
Member

Does postgres support transactions?

@Fluxticks
Copy link
Collaborator Author

That is a great question that I had not considered. The changes were in relation to an error that occured with this as the suggested fix. Turned out the error was actually unrelated, but I thought in theory not bad to implement

@Laura7089
Copy link
Member

Yep, seems like a good idea.

Postgres has transaction support: https://www.postgresql.org/docs/9.5/tutorial-transactions.html. I'll approve this PR but it's probably worth examining transactions as an idea to supercede it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laura7089 Laura7089 Laura7089 approved these changes

@Ryth-cs Ryth-cs Awaiting requested review from Ryth-cs

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB Errors are not rolled back
2 participants
@Fluxticks @Laura7089