New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The findByPk and findById methods should not add the 'id' field when the 'hasPrimaryKeys' property is set to false. #12

Open

lcmuniz opened this issue Mar 27, 2022 · 0 comments

lcmuniz commented Mar 27, 2022 •

edited

Loading

The findByPk and findById methods should not add the 'id' field when the 'hasPrimaryKeys' property is set to false.

I think that line 415 of the model.js file should be

return self.options.hasPrimaryKeys ? self.build({ id: id }) : self.build();

This is because someone might want to set their own id field with a default value and not call it 'id'

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment