Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it easy to extract current parameters #69

Open
ExpandingMan opened this issue Jun 9, 2024 · 0 comments
Open

make it easy to extract current parameters #69

ExpandingMan opened this issue Jun 9, 2024 · 0 comments

Comments

@ExpandingMan
Copy link

ExpandingMan commented Jun 9, 2024

Motivation and description

Currently it's pretty difficult to extract current parameters from a scheduler for two reasons:

  • You typically have to descend into a parameter tree structure to even extract the scheduler state object in the first place. This is quite a pain to do from scratch, even with functors.
  • There is no public method for getting the scheduler state.

The latter problem I think is fixed relatively easily: the currently private _get_opt should be made public. No obvious reason jumped out at my why this couldn't be done, though I'm not all that familiar with the code base.

The former problem I guess should be solved in Optimisers instead since it has Functors as a direct dependency while this does not. I suppose this would be done on the assumption that the schedules for all the leaf nodes are the same, otherwise it would be pretty inefficient.

Possible Implementation

Change _get_opt to public getopt (or whatever). Extracting from tree will have to be worked out more carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant