Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Flux Dependency #52

Closed
maximilian-gelbrecht opened this issue Oct 12, 2023 · 2 comments · Fixed by #55
Closed

Remove Flux Dependency #52

maximilian-gelbrecht opened this issue Oct 12, 2023 · 2 comments · Fixed by #55
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@maximilian-gelbrecht
Copy link
Contributor

The package can be used for all kinds of ML libraries not only Flux. I use it with Lux for example as well. However, it has Flux.jl as a dependency that it will always install. From a quick look over the code the dependency on Flux is only relevant for the Schedulers struct.

If the dependency there is really necessary, one could rewrite this as an extension module that is only loaded when Flux is loaded as well.

@ToucheSir ToucheSir added enhancement New feature or request help wanted Extra attention is needed labels Oct 13, 2023
@maximilian-gelbrecht
Copy link
Contributor Author

If the dependency there is really necessary, one could rewrite this as an extension module that is only loaded when Flux is loaded as well.

I could make a PR for this, but this would also make Julia 1.9 a requirement. What do you think?

@darsnack
Copy link
Member

That would be greatly appreciated. Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants