Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak GoogLeNet and Inception family to match the torchvision implementations #196

Closed
2 tasks done
theabhirath opened this issue Aug 4, 2022 · 3 comments · Fixed by #205
Closed
2 tasks done

Tweak GoogLeNet and Inception family to match the torchvision implementations #196

theabhirath opened this issue Aug 4, 2022 · 3 comments · Fixed by #205
Labels

Comments

@theabhirath
Copy link
Member

theabhirath commented Aug 4, 2022

These changes will make it easier to port over pretrained weights for the models from PyTorch.

@darsnack
Copy link
Member

darsnack commented Aug 4, 2022

A toggle would be a good idea so that the paper variant is still easily available.

@theabhirath theabhirath changed the title Tweak GoogLeNet and InceptionV3 to match the torchvision implementations Tweak GoogLeNet and Inception family to match the torchvision implementations Aug 11, 2022
@pri1311
Copy link
Contributor

pri1311 commented Nov 15, 2022

Hi, this issue seems like a good place to start contributing.

function convolution(kernel_size, inplanes, outplanes, batchNorm; kwargs...)
    if batchNorm
        return basic_conv_bn(kernel_size, inplanes, outplanes; kwargs...)
    else 
        return Conv(kernel_size, inplanes => outplanes; kwargs...)
    end
end

would implementing such a function and the calling it like this
convolution((7, 7), inchannels, 64, batchNorm; stride = 2, pad = 3, bias = bias)
be a good way to refactor code for the particular issue?
Or do you have something else in mind?

@darsnack
Copy link
Member

We already have support for turning off the batch norm here. The remaining task on this issue it to update the code for GoogLeNet to use that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants