From a5214a4b8300c9ed2e4de64c7a37770b424222c7 Mon Sep 17 00:00:00 2001
From: Ian Butterworth <i.r.butterworth@gmail.com>
Date: Thu, 14 Dec 2023 12:43:33 -0500
Subject: [PATCH] comments etc.

---
 benchmarking/benchmark.jl | 7 ++++---
 benchmarking/tooling.jl   | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/benchmarking/benchmark.jl b/benchmarking/benchmark.jl
index 9c48248f..0b664216 100644
--- a/benchmarking/benchmark.jl
+++ b/benchmarking/benchmark.jl
@@ -49,9 +49,9 @@ modelstrings = (
     "EfficientNetv2(:small)",
     "ConvMixer(:small)",
     "ConvNeXt(:small)",
-    # "MLPMixer()", # found no tests
-    # "ResMLP()", # found no tests
-    # "gMLP()", # found no tests
+    # "MLPMixer()", # no tests found
+    # "ResMLP()", # no tests found
+    # "gMLP()", # no tests found
     "ViT(:tiny)",
     "UNet()"
     )
@@ -60,6 +60,7 @@ for (i, modstring) in enumerate(modelstrings)
     @timeit to "$modstring" begin
         @info "Evaluating $i/$(length(modelstrings)) $modstring"
         @timeit to "First Load" eval(Meta.parse(modstring))
+        # second load simulates what might be possible with a proper set-up pkgimage workload
         @timeit to "Second Load" model=eval(Meta.parse(modstring))
         @timeit to "Training" train(model,
             train_loader,
diff --git a/benchmarking/tooling.jl b/benchmarking/tooling.jl
index 72f0e180..94b45b7e 100644
--- a/benchmarking/tooling.jl
+++ b/benchmarking/tooling.jl
@@ -93,10 +93,10 @@ function train(args...;kwargs...)
     try
         _train(args...; kwargs...)
     catch ex
-        rethrow()
+        # rethrow()
         println()
         @error sprint(showerror, ex)
         GC.gc()
         return false
     end
-end
\ No newline at end of file
+end