Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity embedding layers should output Float32 not Float64, as present? #273

Open
ablaom opened this issue Sep 9, 2024 · 0 comments
Open

Comments

@ablaom
Copy link
Collaborator

ablaom commented Sep 9, 2024

While less generic, I'm inclined to agree with the proposal at #272, which is to coerce all data to Float32, with no option to opt out. So I suggest we also make Float32 the output type for the entity embedding layers. This does not appear to be the case at present, and this is complicating resolution of the conflict at #272: When data is not Float32 and is coerced to Float64, a warning is issued, but the warning is breaking certain tests (admittedly fragile) that depend on logging to check certain functionality (warm restarts).

cc @EssamWisam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant