You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While less generic, I'm inclined to agree with the proposal at #272, which is to coerce all data to Float32, with no option to opt out. So I suggest we also make Float32 the output type for the entity embedding layers. This does not appear to be the case at present, and this is complicating resolution of the conflict at #272: When data is not Float32 and is coerced to Float64, a warning is issued, but the warning is breaking certain tests (admittedly fragile) that depend on logging to check certain functionality (warm restarts).
While less generic, I'm inclined to agree with the proposal at #272, which is to coerce all data to
Float32
, with no option to opt out. So I suggest we also makeFloat32
the output type for the entity embedding layers. This does not appear to be the case at present, and this is complicating resolution of the conflict at #272: When data is notFloat32
and is coerced toFloat64
, a warning is issued, but the warning is breaking certain tests (admittedly fragile) that depend on logging to check certain functionality (warm restarts).cc @EssamWisam
The text was updated successfully, but these errors were encountered: