Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Linear builder? #253

Open
ablaom opened this issue May 23, 2024 · 3 comments
Open

Deprecate Linear builder? #253

ablaom opened this issue May 23, 2024 · 3 comments

Comments

@ablaom
Copy link
Collaborator

ablaom commented May 23, 2024

The MLP builder added more recently renders it redundant.

@EssamWisam
Copy link
Collaborator

Agree. Think should also deprecate Short because it's also a special case of MLP and forces specifically three hidden layers (also quite hard to infer the functionality from the name; a 3 layer network can theoretically even approximate discontinuous functions to arbitrary accuracy).

@ablaom
Copy link
Collaborator Author

ablaom commented May 29, 2024

'Short' includes a dropout layer and for this reason is needed in tests, if I remember correctly. I agree the name is not great and we could deprecate to "testing only".

@EssamWisam
Copy link
Collaborator

Sheds light on the possibility of extending MLPs to handle dropout (and maybe batch norm because it's just as common). For instance, for drop out, user can pass a list of probabilities that correspond to the hidden layers and 0 would mean no dropout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants