Metalhead integration #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #206 +/- ##
==========================================
- Coverage 92.27% 89.09% -3.19%
==========================================
Files 9 10 +1
Lines 246 275 +29
==========================================
+ Hits 227 245 +18
- Misses 19 30 +11
Continue to review full report at Codecov.
|
|
Closed in favour of #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #205 and #162.
Does not need FluxML/Metalhead.jl#176 but includes a temporary hack that can be removed when that is resolved. This PR defines a generic
image_builder(Constructor)wrapper, but this won't work as advertised (and cannot be made public) until FluxML/Metalhead.jl#176 is resolved.WIP. See the
image_builderdocstring for more details.Todos (incomplete):
metal(Constructor)(args..., kwargs...)showmethod for the wrappers