Remove "$targetWorkspaceName" from indexer -- as that's a very crude hack

[skurfuerst]

... Instead of manipulating context node path using string replace, we should instead do the following:

if NodeInUserWorkspace is published + should be indexed, create an new context (with same dimension values and DIFFERENT workspace). Then, using this new context, we fetch the published node by node path. Then, we use that one for indexing.

... Discovered together with Christopher at T3CON.

[dfeyer]

@bwaidelich Is this issue always a problem ? And if it's the case, can push a PR to solve it ?

[bwaidelich]

@dfeyer wrong (se)bastian ;)

[dfeyer]

@skurfuerst Ping, is this issue fixed now or did we need to tackle it ?

[dfeyer]

@skurfuerst Ping again, this is quiet old issue, but not sure if it affect the current implementation ?

[skurfuerst]

Hey Dominique,

this is still relevant I think:

Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Flowpack/ElasticSearch/ContentRepositoryAdaptor/Indexer/NodeIndexer.php

Line 144 in a092e41

public function indexNode(NodeInterface $node, $targetWorkspaceName = null)

All the best,
Sebastian

[kdambekalns]

Also the current version that string manipulation is still done:

• Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Indexer/NodeIndexer.php

  Line 264 in 070fded

  $contextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $contextPath);

And in three more places:

• Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Indexer/NodeIndexer.php

  Line 181 in 070fded

  $contextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $contextPath);

• Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Driver/Version1/IndexerDriver.php

  Line 93 in 070fded

  $closestFulltextNodeContextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $closestFulltextNodeContextPath);

• Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Driver/Version2/IndexerDriver.php

  Line 95 in 070fded

  $closestFulltextNodeContextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $closestFulltextNodeContextPath);

These should (re-)use calculateDocumentIdentifier() as defined in

Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Indexer/NodeIndexer.php

Line 259 in 070fded

protected function calculateDocumentIdentifier(NodeInterface $node, $targetWorkspaceName = null)

!

[dfeyer]

@kdambekalns Code duplication is remove here 2e04e1f