Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving a node leads to double-indexed nodes #353

Open
daniellienert opened this issue Sep 10, 2020 · 5 comments
Open

Moving a node leads to double-indexed nodes #353

daniellienert opened this issue Sep 10, 2020 · 5 comments

Comments

@daniellienert
Copy link
Contributor

Currently, the identifier of the elasticsearch document is calculated using the nodepath.
When a node is moved, a new document with a new identifier is added to the index instead of updating the existing.

@baschny
Copy link

baschny commented Apr 5, 2021

why not use the identifier instead of the node-path when finding the nodes to delete/create on move? the identifier doesn't change when moving it, right?

@dfeyer
Copy link
Contributor

dfeyer commented Apr 9, 2021

why not use the identifier instead of the node-path when finding the nodes to delete/create on move? the identifier doesn't change when moving it, right?

Don't remember why we use the context path for this document identifier ... sounds odd ... but some memories could be nice .... maybe in the past the node uuid change during a move operation ?

@baschny
Copy link

baschny commented Apr 9, 2021

We've been running a "patched" version of this that does exactly this (use the Identifier) without a problem. I thought we did a pull request back then, but apparently not. Maybe @remuslazar can provide a pull request?

@remuslazar
Copy link
Contributor

@baschny sure thing!

@remuslazar
Copy link
Contributor

@baschny @dfeyer done, see #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants