ui_template scope does not clean up on configuration change.

[hotNipi]

Current Behavior

User wants to make a template for CSS

1 Drag in the ui_template (default scope "Widget (Group-scoped)")
2 Write or copy/paste the content into
3 Forget to change the template type to "CSS (All Pages)"
4 Deploy
5 Change the template type to "CSS (All Pages)"
6 Deploy

Result:

• there's no errors in console or any other indicators that something went wrong.
• the CSS is not applied to the document head, user cant see any of desired changes
• user can not use this template anymore for CSS (group and page properties are not removed)

Debug panels comparing broken ad correct ui_template for CSS
The broken ui_template "page-back" has values for page and group.

Expected Behavior

Changing the scope should be possible in all ways.

Steps To Reproduce

Steps to reproduce described above

Workaround:
Make new ui_template but pay attention to not deploy for wrong scope

1 Drag in the ui_template (and give it a name)
2 Change the template type to "CSS (All Pages)"
3 Write or copy/paste the content into
4 Deploy

Environment

• Dashboard version: v1.12.2
• Node-RED version:v4.0.0
• Node.js version:v20.14.0
• npm version:
• Platform/OS: Windows 10
• Browser: Chrome

Have you provided an initial effort estimate for this issue?

I can not provide an initial effort estimate

[joepavitt]

Can see the problem:

node-red-dashboard/nodes/widgets/ui_template.js

Lines 12 to 20 in b15c219

	if (config.templateScope === 'local') {
	config.page = ''
	config.ui = ''
	} else if (config.templateScope === 'widget:page') {
	config.ui = ''
	config.group = ''
	} else if (config.templateScope === 'widget:ui') {
	config.page = ''
	config.group = ''

I don't account for the CSS use cases here to clear the unnecessary group and page variables.

[arturv2000]

@joepavitt Noticed that the template does not generate any error if no (page/UI) selected, only gives error when no group is selected. Should it give some kind of error? Should open a separate issue?

[joepavitt]

Yeah, I noticed that too, issue would be great. Thanks @arturv2000