Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in build.yaml / wrong call to build coverage #20

Open
dornech opened this issue Nov 18, 2024 · 0 comments
Open

error in build.yaml / wrong call to build coverage #20

dornech opened this issue Nov 18, 2024 · 0 comments

Comments

@dornech
Copy link

dornech commented Nov 18, 2024

In build.yaml following steps are defined:
image
I think the hatch run test:pytest is wrong here.
a) It calls the test environment which is managed outside in the GitHub action (beside the fact, that for coverage I think there is no difference between different Python/OS version) so this is not helpful and causes overhead.
b) pytest just does not create the coverage report that the subsequent job / codecov action wants to retrieve.

I think the right call to be
hatch test -cover
which should be executed in the "hidden" hatch-test environment

However, I still have not yet resolved the coverage file not being found by the CodeCov action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant