Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Adding Fixed Edges Within The Domain #28

Open
angelmusonda opened this issue May 10, 2024 · 4 comments
Open

Feature Request: Adding Fixed Edges Within The Domain #28

angelmusonda opened this issue May 10, 2024 · 4 comments

Comments

@angelmusonda
Copy link

Hi Flo,

I find your library extremely useful for my work.

I would like to suggest adding a feature to define fixed edges within the boundary. This would enhance control by allowing users to preserve critical edges for certain purposes.

Angel

@FloSewn
Copy link
Owner

FloSewn commented May 13, 2024

Hey Angel,

thanks for your kind feedback.
Your idea sounds very promising! I put it on my to-do-list and I will try to add that feature as soon as possible :-)

Cheers
Flo

@angelmusonda
Copy link
Author

Great! Thanks @FloSewn

@FloSewn
Copy link
Owner

FloSewn commented Jul 5, 2024

Hey Angel,

the "fixed-edges" feature is now available in the newest release v1.3.3.
I also included a new example (input-file and cpp-file).

It is not yet possible to add fixed edges via CSV files, but I want to add that as soon as possible.

Maybe you can try it out if you want and tell me about possible bugs ;-)

Thanks again for your idea!

Cheers,
Flo

@FloSewn FloSewn closed this as completed Jul 5, 2024
@FloSewn FloSewn reopened this Jul 5, 2024
@angelmusonda
Copy link
Author

Hi @FloSewn,

Thank you so much for adding this feature. It works well in most cases.

However, I've encountered two limitations:

  1. It doesn't work if one of the fixed vertices lies on the exterior boundary.
  2. The tri2quad_modification breaks the fixed edges.

I'm unsure if these issues can be resolved, especially the second one, as it's still a work in progress.

Regards,
Angel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants