Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using .equals instead of Objects.equals when applicable #663

Open
Luro02 opened this issue Dec 17, 2024 · 0 comments
Open

Suggest using .equals instead of Objects.equals when applicable #663

Luro02 opened this issue Dec 17, 2024 · 0 comments
Labels
enhancement New feature or request low-priority new-lint A new lint. unnecessary-complexity unresolved Some decisions have not been made yet or it is not obvious what should be detected.

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Dec 17, 2024

What it does

When the left-hand side or right-hand side is guaranteed to not be null, it is more readable to use rhs.equals(lhs) or lhs.equals(rhs) than Objects.equals(lhs, rhs).

Unresolved: Is this more readable or just pedantic?

Lint Name

No response

Category

No response

Example

Objects.equals(variable, MY_CONSTANT)

Could be written as:

MY_CONSTANT.equals(variable)
@Luro02 Luro02 added enhancement New feature or request new-lint A new lint. unnecessary-complexity low-priority unresolved Some decisions have not been made yet or it is not obvious what should be detected. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low-priority new-lint A new lint. unnecessary-complexity unresolved Some decisions have not been made yet or it is not obvious what should be detected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Luro02