Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using contains (or Arrays.asList(....).contains) #620

Open
Luro02 opened this issue Oct 11, 2024 · 0 comments
Open

Suggest using contains (or Arrays.asList(....).contains) #620

Luro02 opened this issue Oct 11, 2024 · 0 comments
Labels
api lints that check for code that reimplements parts of the api enhancement New feature or request new-lint A new lint.

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Oct 11, 2024

What it does

Finds code where contains is manually implemented through a for loop.

Lint Name

USE_CONTAINS

Category

api

Example

private static final String[] DIRECTIONS = {"up", "down", "left", "right"};

boolean matchFound = false;
for (String direction : DIRECTIONS) {
    if (direction.equals(toFind)) {
        matchFound = true;
    }
}

Could be written as:

boolean matchFound = Arrays.asList(DIRECTIONS).contains(toFind);
@Luro02 Luro02 added enhancement New feature or request new-lint A new lint. api lints that check for code that reimplements parts of the api labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api lints that check for code that reimplements parts of the api enhancement New feature or request new-lint A new lint.
Projects
None yet
Development

No branches or pull requests

1 participant