Detect code that can be replaced by Objects.requireNonNullElse/Objects.requireNonNullElseGet

[Luro02]

What it does

These two methods could be used to simplify some code:

• https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Objects.html#requireNonNullElse(T,T)
• https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Objects.html#requireNonNullElseGet(T,java.util.function.Supplier)

where one checks if a value is null, then returns/breaks/assigns a default value or calls some code or otherwise uses the non-null value.

The amount of code that triggers this lint, is likely minimal, especially, when Objects.requireNonNullElseGet cannot be suggested, which makes this a low-priority issue.

Lint Name

USE_OBJECTS_REQUIRE_NON_NULL

Category

api

Example

Character defaultRepr = super.getDefaultRepresentation(forPlayer);
if (defaultRepr == null) {
    return Character.toLowerCase(this.callsign);
} else {
    return defaultRepr;
}

Could be written as:

Character defaultRepr = super.getDefaultRepresentation(forPlayer);
return Objects.requireNonNullElseGet(defaultRepr, () -> Character.toLowerCase(this.callsign));