Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exometer_report gen_server doesn't restart reporters after restarting by supervisor. #85

Open
surik opened this issue Sep 27, 2016 · 5 comments

Comments

@surik
Copy link
Contributor

surik commented Sep 27, 2016

exometer_report may be terminated by some reason and it also terminates all reporters.
Should they be restarted together with exometer_report gen_server?

@surik
Copy link
Contributor Author

surik commented Sep 27, 2016

For example, exometer_report gen_server may be crashed here during reporting function metric if my function callback does something like throw(timeout)

@uwiger
Copy link
Member

uwiger commented Sep 27, 2016

PR #74 refers to this problem.

@surik
Copy link
Contributor Author

surik commented Sep 27, 2016

@uwiger good! What do you think about that https://github.com/Feuerlabs/exometer_core/blob/master/src/exometer_function.erl#L232 only catches error class exceptions? It may be reason of reaching max restarts.

@uwiger
Copy link
Member

uwiger commented Sep 27, 2016

Well ... I guess it wouldn't hurt to also catch other categories, even though the likelihood of get_value() raising other exceptions should be very low. :)

@beano
Copy link

beano commented Sep 28, 2016

I've seen this too. Maybe issue #36 is also related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants