Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Datadog tags to statsd [exometer_report_statsd] #156

Open
nicolasgarnil opened this issue Aug 19, 2017 · 1 comment
Open

Send Datadog tags to statsd [exometer_report_statsd] #156

nicolasgarnil opened this issue Aug 19, 2017 · 1 comment

Comments

@nicolasgarnil
Copy link

nicolasgarnil commented Aug 19, 2017

Problem

The reporter exometer_report_statsd doesn't support including Datadog tags in the datagram which is sent to statsd.

Solution

Be able to pass the tags to :exometer.update as well as the metric value.

E.g:

:exometer.update[:app_name, :webapp, :resp_time], %{value: 25, tags: [algorithm: "one"]}

@nicolasgarnil nicolasgarnil changed the title Send Datadog tags to statsd [exometer_report_statsd reporter] Send Datadog tags to statsd [exometer_report_statsd] Aug 19, 2017
@uwiger
Copy link
Member

uwiger commented Aug 21, 2017

Passing tags in the update operation would be difficult. However, it would be possible to add tags as part of Extra for a given subscription entry, and extend the exometer_report_statsd module to look for a tags option and append those tags to the output line. One could also add a tags option when initializing a statsd reporter. Actually, both these could be implemented, and the exometer_report callback could check both for tags in Extra and in the reporter state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants