Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grids for the test-suite #817

Open
KnutAM opened this issue Oct 11, 2023 · 2 comments
Open

Grids for the test-suite #817

KnutAM opened this issue Oct 11, 2023 · 2 comments

Comments

@KnutAM
Copy link
Member

KnutAM commented Oct 11, 2023

Much of Ferrite's code is only tested for grids from the generate_grid function, but @koehlerson and I discussed that it would be valuable to have some grids available for testing that unstructured, stemming from e.g. Gmsh and Abaqus.

We recently found some code, not yet in Ferrite, that worked well on grids from generate_grid, but not for unstructured grids.

One suggestion would be to have a list of different types of relatively small grids for use with testing, both with the same cell type and mixed celltypes. One possibility could be to define something like

const test_grids = Dict(
 "GenTriangle" => generate_grid(Triangle, (3,3)),
 "GmshTriangle" => togrid(joinpath(@__DIR__, "triangle.msh")),
 "AbaTriangle" => get_ferrite_grid(joinpath(@__DIR__, "triangle.inp")),
 "GmshTriQuad" => ...
 "AbaTriQuad" => ...
)

just to make sure to cover some special cases during testing.
This would also serve as "reverse-ci" (cf. #797) for the mesh parsing.

Thoughts?

@termi-official
Copy link
Member

Maybe we can just dump some problematic unstructured grids in a test assets folder or hand-generate them tailored for specific corner cases to cover? Otherwise we might need to start thinking about randomization of the tests, if we want to test all combinations of every type of mesh parser+every type of element combination+every type of unstructuredness.

@termi-official
Copy link
Member

First attempt in #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants