Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linear Shell tutorial uses internals #1034

Open
KristofferC opened this issue Jul 31, 2024 · 3 comments
Open

Linear Shell tutorial uses internals #1034

KristofferC opened this issue Jul 31, 2024 · 3 comments

Comments

@KristofferC
Copy link
Collaborator

Ferrite.jl/docs/src/literate-tutorials/linear_shell.jl

Line 267 in f7f2592

shape_reference_gradient(cv::CellValues, q_point, i) = cv.fun_values.dNdξ[i, q_point]

Should this be a Ferrite function?
@KnutAM
Copy link
Member

KnutAM commented Jul 31, 2024

xref #842

@KnutAM
Copy link
Member

KnutAM commented Jul 31, 2024 •
edited
Loading

And #997 actually suggests that we should include this function (and reference_shape_value) in Ferrite, I think that would be a good option!

@termi-official
Copy link
Member

Ferrite.jl/docs/src/literate-tutorials/linear_shell.jl

Line 267 in f7f2592

shape_reference_gradient(cv::CellValues, q_point, i) = cv.fun_values.dNdξ[i, q_point]

Should this be a Ferrite function?

My take on this would be that we expose all of these functions to public, so users can write custom FEValues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KristofferC @termi-official @KnutAM