Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate functions for creating quadrature rule instead of the QuadratureRule constructor #1002

Closed
KristofferC opened this issue Jun 30, 2024 · 2 comments
Milestone

Comments

@KristofferC
Copy link
Collaborator

#991 (comment)

I think the current way of creating quadrature rules is not ideal. For example we write:

qr = QuadratureRule{RefTetrahedron}(2)

but there are many quadrature rules and it isn't clear which one this creates etc. This was changed by me in #58 and 8 years later I am suggesting we change it back to standard functions like:

create_legendre_quadrature(RefTetrahedron::RefShape, 1::Int)
create_lobotto_quadrature(RefCube::RefShape, 1::Int)

etc. Should be decided before 1.0 I guess.

@KristofferC KristofferC added this to the v1.0.0 milestone Jun 30, 2024
@fredrikekre
Copy link
Member

#1001

@KristofferC
Copy link
Collaborator Author

Pretty sure I only created one issue... Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants