-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java.lang.ClassNotFoundException: org.hibernate.engine.spi.SharedSessionContractImplementor #134
Comments
I think that there is fundamental incompatibility between various "minor" Hibernate versions, so that it is not possible for this module to work against 5.0, 5.1 AND 5.2. I forget what were the trade-offs, but I think this problem would go away with Hibernate 5.2 or higher. |
@cowtowncoder what's peculiar is that I cannot see where org.hibernate.engine.spi.SharedSessionContractImplementor is referenced.. |
Perhaps it is referenced indirectly... although that would be bit odd, would expect that not to happen without module somehow referencing it. |
@cowtowncoder I was able to "fix" this by checking out the 2.9.7 tag and changing the Hibernate version to 5.1.17.Final and using that artifact. Only possible workaround I can think of is to introduce a new module for every major version eg. hibernate5 hibernate52 hibernate53 |
Yes, I think that was the conclusion. One small thing that might be helpful would be to at least document which versions of Hibernate module is compatible with -- to me the least bad option would seem to be to try to support as many of the latest 5.x (5.4, 5.3, if possible 5.2....) as possible. One critical short-coming is that this module does not have active maintainer. If there was one, that person could both figure out contraints and make decisions. Problem for me is that I will try to help as I can, but I do not use Hibernate myself and am not familiar with its internals (to the degree I could fully own this module). Module was added as a contribution, and is clearly useful, so I feel bad for it being bit of an oprhan. So, if you or anyone else interested and passionate enough wanted to look into things, I would be happy to give more access and authority -- this would be great for users. And I think it is something that could be valuable for the new owner: doing important and quite visible OSS work that benefits many. That being said, I appreciate your reaching out and helping by sharing work-around you have found, additional information. That is helpful as well. |
After updating to jackson-datatype-hibernate 2.9.7 (Hibernate 5.1.7 on the classpath) I found that PersistentCollectionSerializer cannot be instantiated when trying to register the module due to a cnfe..
The text was updated successfully, but these errors were encountered: