Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when using matrix for the arugument sigma in GaussianKernel #67

Open
tinachentc opened this issue Nov 1, 2023 · 1 comment
Open

Comments

@tinachentc
Copy link

tinachentc commented Nov 1, 2023

Hi,

I'm trying the example of GaussianKernel-
mat = torch.randn(3, 3, dtype=torch.float64)
sym_mat = mat @ mat.T
K = falkon.kernels.GaussianKernel(sigma=sym_mat)

But I got the error-
''.../falkon/kernels/distance_kernel.py", line 33, in validate_sigma
raise ValueError("sigma must be a scalar or a vector.")
ValueError: sigma must be a scalar or a vector.

Is the current version of falkon accept matrix for the sigma argument? Could you help with this issue? FYI, I'm using falkon 0.8.4 with torch version 1.13.0 and python 3.9. There's no problem when I use a scalar or a vector for the argument sigma.

Could you help with this? Thanks!

@Giodiro
Copy link
Contributor

Giodiro commented Nov 21, 2023

Hi!
Yes, matrix sigma is not supported. Feel free to contribute to this if you wish!
The relevant function which needs to add support is here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants