Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speakers formatting text near penta image looks out of place #182

Closed
modlin opened this issue Feb 9, 2021 · 2 comments · May be fixed by #183
Closed

speakers formatting text near penta image looks out of place #182

modlin opened this issue Feb 9, 2021 · 2 comments · May be fixed by #183

Comments

@modlin
Copy link
Contributor

modlin commented Feb 9, 2021 •
edited
Loading

instructions/fosdem2021/speakers.md:

That is what will be broadcast is to the right of Penta image but starting only to the image's bottom right.

Usually for languages read line-wise top to bottom, even beside an image, text lines start at the top rather than bottom, unless something else already occupies the top and needs to push text down. But here there isn't anything, making this current bottom-starter line looking a bit out of place.

Screenshot: Penta image with text off to right bottom
@modlin
Copy link
Contributor Author

modlin commented Feb 9, 2021

Possible way to fix is to just not do text wrapping on the side, leave image's side reserved for just white space, and instead have text begin on a new line beneath the image.

I'll send a pull request for this suggestion.

modlin added a commit to modlin/video that referenced this issue Feb 9, 2021
@modlin
fix instructions speakers formatting text wrap around penta img
6c366b2 
"This is what will be broadcast" move beneath image and begin on its own line.

Indent to show Image and sentence are part of parent "Validate your final video" checklist step.

Fixes FOSDEM#182
@modlin modlin mentioned this issue Feb 9, 2021
Open
@markvdb
Copy link
Member

markvdb commented Oct 20, 2023

@modlin thx for your pull request.

Closing because not relevant anymore for 2024.

@markvdb markvdb closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix instructions speakers formatting text wrap around penta img modlin/video
2 participants
@markvdb @modlin